Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: breaking function signature on showImportModal onSuceessHandler #6011

Conversation

fourdim
Copy link
Contributor

@fourdim fourdim commented Mar 5, 2024

This will fix the breaking change introduced in
toeverything/blocksuite@da781df
This should be merged after the next BlockSuite bump.

Copy link

graphite-app bot commented Mar 5, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

@fourdim
Copy link
Contributor Author

fourdim commented Mar 5, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fourdim and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Mar 5, 2024

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.72%. Comparing base (dce3b59) to head (0ff1e8d).

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #6011   +/-   ##
=======================================
  Coverage   61.72%   61.72%           
=======================================
  Files         461      461           
  Lines       21275    21275           
  Branches     1885     1885           
=======================================
  Hits        13131    13131           
  Misses       7922     7922           
  Partials      222      222           
Flag Coverage Δ
server-test 71.16% <ø> (ø)
unittest 40.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@doodlewind doodlewind enabled auto-merge (squash) March 5, 2024 06:36
@doodlewind doodlewind disabled auto-merge March 5, 2024 08:18
@fourdim fourdim force-pushed the 03-04-fix_breaking_function_signature_on_showImportModal_onSuceessHandler branch from 3ac3601 to 6a1b528 Compare March 5, 2024 18:42
Copy link

graphite-app bot commented Mar 5, 2024

Merge activity

…6011)

This will fix the breaking change introduced in
toeverything/blocksuite@da781df
This should be merged after the next BlockSuite bump.
@fourdim fourdim force-pushed the 03-04-fix_breaking_function_signature_on_showImportModal_onSuceessHandler branch from 6a1b528 to 0ff1e8d Compare March 5, 2024 18:51
@graphite-app graphite-app bot merged commit 0ff1e8d into canary Mar 5, 2024
40 of 42 checks passed
@graphite-app graphite-app bot deleted the 03-04-fix_breaking_function_signature_on_showImportModal_onSuceessHandler branch March 5, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants