-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(core): new back&forward button base on workbench #6012
Conversation
Your org has enabled the Graphite merge queue for merging into canaryYou must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. You can enable merging using labels in your Graphite merge queue settings. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
0636a24
to
57f2c10
Compare
57f2c10
to
2793efb
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 7c76c25. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## canary #6012 +/- ##
==========================================
- Coverage 62.49% 61.64% -0.86%
==========================================
Files 436 460 +24
Lines 20863 21267 +404
Branches 1833 1882 +49
==========================================
+ Hits 13039 13110 +71
- Misses 7605 7935 +330
- Partials 219 222 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
packages/frontend/core/src/components/app-sidebar/sidebar-header/index.tsx
Show resolved
Hide resolved
It seems history back/forward with keyboard shortcut does not work well. |
Merge activity
|
2793efb
to
4285733
Compare
# feature: ## In Browser: - hidden back&forward button in sidebar. - back and forward is equal with `window.history.back()` `window.history.forward()` ## In Desktop: - Back and forward can be controlled through the sidebar, cmdk, and shortcut keys. - back and forward act on the currently **active** view. - buttons change disable&enable style based on current active view history # Refactor: Move app-sidebar and app-container from @affine/component to @affine/core
4285733
to
7c76c25
Compare
feature:
In Browser:
window.history.back()
window.history.forward()
In Desktop:
Refactor:
Move app-sidebar and app-container from @affine/component to @affine/core