Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: do not fail build for a non-fatal error #6017

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Mar 5, 2024

No description provided.

Copy link

graphite-app bot commented Mar 5, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Collaborator Author

pengx17 commented Mar 5, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the app:electron Related to electron app label Mar 5, 2024
@pengx17 pengx17 marked this pull request as ready for review March 5, 2024 08:04
Copy link

nx-cloud bot commented Mar 5, 2024

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.73%. Comparing base (7c55472) to head (65b3215).

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #6017   +/-   ##
=======================================
  Coverage   61.73%   61.73%           
=======================================
  Files         461      461           
  Lines       21268    21268           
  Branches     1883     1883           
=======================================
  Hits        13129    13129           
  Misses       7917     7917           
  Partials      222      222           
Flag Coverage Δ
server-test 71.16% <ø> (ø)
unittest 40.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 force-pushed the build-test branch 2 times, most recently from eca231d to 21dca3d Compare March 5, 2024 08:09
Copy link

graphite-app bot commented Mar 5, 2024

Merge activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:electron Related to electron app
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants