Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix journal missing after refresh #6022

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Mar 5, 2024

No description provided.

Copy link

graphite-app bot commented Mar 5, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

@EYHN EYHN marked this pull request as ready for review March 5, 2024 11:06
Copy link
Member Author

EYHN commented Mar 5, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @EYHN and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the mod:infra Environment related issues and discussions label Mar 5, 2024
Copy link

nx-cloud bot commented Mar 5, 2024

@EYHN EYHN requested a review from pengx17 March 5, 2024 11:07
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 61.63%. Comparing base (c1afdb9) to head (5d8dea0).

Files Patch % Lines
...s/common/infra/src/workspace/engine/sync/engine.ts 16.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6022      +/-   ##
==========================================
- Coverage   61.64%   61.63%   -0.02%     
==========================================
  Files         461      461              
  Lines       21269    21275       +6     
  Branches     1882     1884       +2     
==========================================
+ Hits        13112    13113       +1     
- Misses       7935     7940       +5     
  Partials      222      222              
Flag Coverage Δ
server-test 71.04% <ø> (ø)
unittest 40.60% <16.66%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EYHN EYHN force-pushed the eyhn/fix/journal-missing branch from 57e1f26 to a5843e6 Compare March 5, 2024 11:26
@EYHN EYHN requested a review from pengx17 March 5, 2024 11:27
Copy link

graphite-app bot commented Mar 5, 2024

Merge activity

@graphite-app graphite-app bot merged commit 5d8dea0 into canary Mar 5, 2024
42 checks passed
@graphite-app graphite-app bot deleted the eyhn/fix/journal-missing branch March 5, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:infra Environment related issues and discussions
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants