Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): canvas font loading in desktop #6025

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Mar 5, 2024

const officialDomains = new Set(['app.affine.pro', 'affine.fail']);
if (!officialDomains.has(window.location.host)) {

window.location.host will be '.' in desktop (Version 0.12.2 (0.12.2)).

Screenshot 2024-03-05 at 20 25 10

Copy link

nx-cloud bot commented Mar 5, 2024

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.63%. Comparing base (0ff1e8d) to head (01dbbb9).

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6025      +/-   ##
==========================================
- Coverage   61.72%   61.63%   -0.09%     
==========================================
  Files         461      460       -1     
  Lines       21275    21274       -1     
  Branches     1885     1884       -1     
==========================================
- Hits        13131    13112      -19     
- Misses       7922     7940      +18     
  Partials      222      222              
Flag Coverage Δ
server-test 71.04% <ø> (-0.13%) ⬇️
unittest 40.59% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

typecheck failed

@fundon fundon marked this pull request as draft March 6, 2024 03:31
@fundon fundon marked this pull request as ready for review March 6, 2024 03:40
@fundon
Copy link
Contributor Author

fundon commented Mar 6, 2024

Not currently considering #2646

@Brooooooklyn Brooooooklyn merged commit 5d63ca0 into toeverything:canary Mar 6, 2024
33 of 35 checks passed
@fundon fundon deleted the fix-fonts-load branch March 6, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants