Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix cmdk not show current page #6031

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Mar 6, 2024

No description provided.

Copy link

graphite-app bot commented Mar 6, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Member Author

EYHN commented Mar 6, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @EYHN and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Mar 6, 2024

@EYHN EYHN marked this pull request as ready for review March 6, 2024 06:05
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 61.63%. Comparing base (5d63ca0) to head (633a5ba).

Files Patch % Lines
packages/common/infra/src/livedata/react.ts 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6031      +/-   ##
==========================================
- Coverage   61.72%   61.63%   -0.09%     
==========================================
  Files         461      461              
  Lines       21275    21277       +2     
  Branches     1885     1885              
==========================================
- Hits        13131    13114      -17     
- Misses       7922     7942      +20     
+ Partials      222      221       -1     
Flag Coverage Δ
server-test 71.04% <ø> (-0.12%) ⬇️
unittest 40.59% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the mod:infra Environment related issues and discussions label Mar 6, 2024
Copy link

graphite-app bot commented Mar 6, 2024

Merge activity

@graphite-app graphite-app bot merged commit 633a5ba into canary Mar 6, 2024
38 of 41 checks passed
@graphite-app graphite-app bot deleted the eyhn/fix/cmdk-location branch March 6, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:infra Environment related issues and discussions
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants