Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): inject correct locker to request scope mutex #6140

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

forehalo
Copy link
Member

No description provided.

Copy link

graphite-app bot commented Mar 15, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Member Author

forehalo commented Mar 15, 2024

Copy link

nx-cloud bot commented Mar 15, 2024

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 84.96732% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 60.94%. Comparing base (f18133a) to head (4702c1a).

Files Patch % Lines
packages/backend/server/src/plugins/redis/mutex.ts 28.00% 18 Missing ⚠️
...ackend/server/src/fundamentals/mutex/local-lock.ts 85.71% 3 Missing and 1 partial ⚠️
...ages/backend/server/src/fundamentals/mutex/lock.ts 95.65% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6140      +/-   ##
==========================================
+ Coverage   60.83%   60.94%   +0.10%     
==========================================
  Files         501      504       +3     
  Lines       22878    22850      -28     
  Branches     2041     2046       +5     
==========================================
+ Hits        13918    13925       +7     
+ Misses       8729     8693      -36     
- Partials      231      232       +1     
Flag Coverage Δ
server-test 70.79% <84.96%> (+0.16%) ⬆️
unittest 39.40% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the test Related to test cases label Mar 15, 2024
@forehalo forehalo changed the base branch from canary to darksky/feat-distributed-lock March 15, 2024 09:18
Copy link

graphite-app bot commented Mar 19, 2024

Merge activity

@forehalo forehalo force-pushed the darksky/feat-distributed-lock branch from bf652dd to f18133a Compare March 19, 2024 02:17
@forehalo forehalo changed the base branch from darksky/feat-distributed-lock to canary March 19, 2024 02:27
@graphite-app graphite-app bot merged commit 4702c1a into canary Mar 19, 2024
33 checks passed
@graphite-app graphite-app bot deleted the 61/fix-mutex-injection branch March 19, 2024 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:server test Related to test cases
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants