Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support esc shortcut on input-edit #6143

Merged
merged 2 commits into from
Mar 16, 2024

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Mar 15, 2024

Closes: TOV-705

  • support ESC shortcut
  • stop propagation to BlockSuite
Screen.Recording.2024-03-15.at.17.27.37.mov

Copy link

nx-cloud bot commented Mar 15, 2024

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 60.46%. Comparing base (eec24db) to head (9b5b99d).

Files Patch % Lines
...frontend/component/src/ui/editable/inline-edit.tsx 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6143      +/-   ##
==========================================
- Coverage   60.48%   60.46%   -0.02%     
==========================================
  Files         495      494       -1     
  Lines       22457    22461       +4     
  Branches     2004     2006       +2     
==========================================
- Hits        13583    13582       -1     
- Misses       8645     8650       +5     
  Partials      229      229              
Flag Coverage Δ
server-test 70.17% <ø> (ø)
unittest 39.57% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fundon fundon force-pushed the feat/support-esc-on-inline-edit branch 2 times, most recently from c80a073 to c83267f Compare March 16, 2024 06:56
@EYHN EYHN enabled auto-merge (squash) March 16, 2024 12:32
auto-merge was automatically disabled March 16, 2024 12:41

Head branch was pushed to by a user without write access

@fundon fundon force-pushed the feat/support-esc-on-inline-edit branch from c83267f to 9b5b99d Compare March 16, 2024 12:41
@EYHN EYHN enabled auto-merge (squash) March 16, 2024 13:05
@EYHN EYHN merged commit 636fa50 into toeverything:canary Mar 16, 2024
32 of 34 checks passed
@fundon fundon deleted the feat/support-esc-on-inline-edit branch March 17, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants