Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): adjust app sidebar's style #6162

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

CatsJuice
Copy link
Member

No description provided.

Copy link

graphite-app bot commented Mar 18, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

@CatsJuice CatsJuice marked this pull request as ready for review March 18, 2024 02:36
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CatsJuice and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Mar 18, 2024

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 60.12%. Comparing base (2a019d4) to head (b2f34d1).

Files Patch % Lines
...frontend/core/src/components/app-sidebar/index.tsx 0.00% 3 Missing ⚠️
...s/frontend/core/src/components/workspace/index.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6162      +/-   ##
==========================================
+ Coverage   60.04%   60.12%   +0.08%     
==========================================
  Files         509      509              
  Lines       23512    23512              
  Branches     2150     2150              
==========================================
+ Hits        14117    14136      +19     
+ Misses       9134     9116      -18     
+ Partials      261      260       -1     
Flag Coverage Δ
server-test 70.55% <ø> (+0.12%) ⬆️
unittest 38.69% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CatsJuice CatsJuice force-pushed the catsjuice/sidebar-optimization branch from 4cf960d to e16f5eb Compare March 18, 2024 07:31
@CatsJuice CatsJuice force-pushed the catsjuice/sidebar-optimization branch from e16f5eb to e1e54e4 Compare March 19, 2024 03:44
@hwangdev97
Copy link
Member

When can we merge this part ?

@CatsJuice CatsJuice requested a review from EYHN March 25, 2024 10:10
Copy link

graphite-app bot commented Mar 25, 2024

Merge activity

@pengx17 pengx17 force-pushed the catsjuice/sidebar-optimization branch from e1e54e4 to b2f34d1 Compare March 25, 2024 10:26
@graphite-app graphite-app bot merged commit b2f34d1 into canary Mar 25, 2024
40 checks passed
@graphite-app graphite-app bot deleted the catsjuice/sidebar-optimization branch March 25, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants