Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(infra): new doc sync engine #6205

Merged
merged 1 commit into from
Mar 22, 2024
Merged

feat(infra): new doc sync engine #6205

merged 1 commit into from
Mar 22, 2024

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Mar 19, 2024

Copy link

graphite-app bot commented Mar 19, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Member Author

EYHN commented Mar 19, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @EYHN and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added mod:infra Environment related issues and discussions test Related to test cases app:core mod:workspace-impl labels Mar 19, 2024
Copy link

nx-cloud bot commented Mar 19, 2024

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 45.50781% with 558 lines in your changes are missing coverage. Please review.

Project coverage is 60.03%. Comparing base (05c44db) to head (34703a3).

Files Patch % Lines
...frontend/workspace-impl/src/local/doc-indexeddb.ts 0.00% 88 Missing ⚠️
...es/common/infra/src/workspace/engine/doc/remote.ts 60.20% 62 Missing and 14 partials ⚠️
...es/frontend/workspace-impl/src/local/doc-sqlite.ts 0.00% 68 Missing ⚠️
packages/frontend/workspace-impl/src/cloud/doc.ts 3.17% 61 Missing ⚠️
...s/common/infra/src/workspace/engine/doc/storage.ts 68.30% 42 Missing and 3 partials ⚠️
packages/backend/server/src/core/doc/manager.ts 53.57% 26 Missing ⚠️
...ges/common/infra/src/workspace/engine/doc/index.ts 61.90% 24 Missing ⚠️
...ges/common/infra/src/workspace/engine/doc/local.ts 77.66% 18 Missing and 5 partials ⚠️
packages/common/infra/src/storage/kv.ts 0.00% 22 Missing ⚠️
.../workspace-impl/src/local/doc-broadcast-channel.ts 0.00% 19 Missing ⚠️
... and 22 more
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6205      +/-   ##
==========================================
- Coverage   60.59%   60.03%   -0.56%     
==========================================
  Files         498      506       +8     
  Lines       22990    23495     +505     
  Branches     2080     2149      +69     
==========================================
+ Hits        13930    14105     +175     
- Misses       8809     9131     +322     
- Partials      251      259       +8     
Flag Coverage Δ
server-test 70.45% <51.85%> (-0.19%) ⬇️
unittest 38.53% <44.96%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EYHN EYHN force-pushed the eyhn/feat/new-sync branch 2 times, most recently from 6aaf83a to e6aabb0 Compare March 22, 2024 07:28
@EYHN EYHN requested a review from forehalo March 22, 2024 09:19
@EYHN EYHN force-pushed the eyhn/feat/new-sync branch 5 times, most recently from 1344a5a to 2e805df Compare March 22, 2024 16:29
Copy link

graphite-app bot commented Mar 22, 2024

Merge activity

@graphite-app graphite-app bot merged commit 34703a3 into canary Mar 22, 2024
36 of 38 checks passed
@graphite-app graphite-app bot deleted the eyhn/feat/new-sync branch March 22, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core app:electron Related to electron app app:server docs Improvements or additions to documentation mod:i18n Related to i18n mod:infra Environment related issues and discussions mod:store mod:workspace-impl test Related to test cases
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants