Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(electron): enable css text autospace #6218

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Mar 20, 2024

before

CleanShot 2024-03-20 at 10.38.50@2x.png

after

CleanShot 2024-03-20 at 10.39.08@2x.png

Copy link

graphite-app bot commented Mar 20, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

@EYHN EYHN marked this pull request as ready for review March 20, 2024 02:38
Copy link
Member Author

EYHN commented Mar 20, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @EYHN and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the app:electron Related to electron app label Mar 20, 2024
Copy link

nx-cloud bot commented Mar 20, 2024

@EYHN EYHN requested a review from pengx17 March 20, 2024 02:39
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.87%. Comparing base (fce4484) to head (5623c09).

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6218      +/-   ##
==========================================
- Coverage   60.87%   60.87%   -0.01%     
==========================================
  Files         508      508              
  Lines       22956    22956              
  Branches     2074     2074              
==========================================
- Hits        13975    13974       -1     
- Misses       8728     8729       +1     
  Partials      253      253              
Flag Coverage Δ
server-test 70.95% <ø> (ø)
unittest 39.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Mar 20, 2024

Merge activity

Copy link
Collaborator

@pengx17 pengx17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if this is stable enough. may add an option to settings and let it to be enabled by the user

@graphite-app graphite-app bot merged commit 5623c09 into canary Mar 20, 2024
37 of 41 checks passed
@graphite-app graphite-app bot deleted the eyhn/feat/css-autospace branch March 20, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:electron Related to electron app
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants