Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): open new page on meta-clicking a page link #6220

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Mar 20, 2024

No description provided.

Copy link

graphite-app bot commented Mar 20, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Collaborator Author

pengx17 commented Mar 20, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Mar 20, 2024

@pengx17 pengx17 requested a review from EYHN March 20, 2024 04:03
@pengx17 pengx17 marked this pull request as ready for review March 20, 2024 04:03
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 60.85%. Comparing base (5623c09) to head (7adb89f).

Files Patch % Lines
...core/src/modules/workbench/view/workbench-link.tsx 0.00% 7 Missing ⚠️
...core/src/modules/workbench/view/workbench-root.tsx 0.00% 2 Missing ⚠️
...d/core/src/modules/workbench/entities/workbench.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6220      +/-   ##
==========================================
- Coverage   60.87%   60.85%   -0.02%     
==========================================
  Files         508      508              
  Lines       22956    22963       +7     
  Branches     2074     2076       +2     
==========================================
  Hits        13974    13974              
- Misses       8729     8736       +7     
  Partials      253      253              
Flag Coverage Δ
server-test 70.95% <ø> (ø)
unittest 39.02% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Mar 20, 2024

Merge activity

@pengx17 pengx17 force-pushed the xp/03-20-feat_core_open_new_page_on_meta-clicking_a_page_link branch from a449f5d to 7adb89f Compare March 20, 2024 05:38
@graphite-app graphite-app bot merged commit 7adb89f into canary Mar 20, 2024
39 of 41 checks passed
@graphite-app graphite-app bot deleted the xp/03-20-feat_core_open_new_page_on_meta-clicking_a_page_link branch March 20, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants