fix(electron): optimize electron open/close on mac #6224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pengx17
commented
Mar 20, 2024
•
pengx17
commented
- never close main window on mac to allow it to be quickly open
- make the browser show a bit faster
- brought up app window when clicking some menu items
Your org has enabled the Graphite merge queue for merging into canaryYou must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. You can enable merging using labels in your Graphite merge queue settings. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 65ab6c8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
pengx17
force-pushed
the
xp/03-20-fix_electron_optimize_electron_open_close_on_mac
branch
from
4454fd8
to
5506b91
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## canary #6224 +/- ##
==========================================
- Coverage 60.85% 60.77% -0.09%
==========================================
Files 508 508
Lines 22964 22964
Branches 2076 2075 -1
==========================================
- Hits 13975 13956 -19
- Misses 8737 8755 +18
- Partials 252 253 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
EYHN
approved these changes
Mar 20, 2024
pengx17
force-pushed
the
xp/03-20-fix_electron_optimize_electron_open_close_on_mac
branch
from
5506b91
to
af2c40d
Compare
Merge activity
|
1. never close main window on mac to allow it to be quickly open 1. make the browser show a bit faster 2. brought up app window when clicking some menu items
pengx17
force-pushed
the
xp/03-20-fix_electron_optimize_electron_open_close_on_mac
branch
from
af2c40d
to
65ab6c8
Compare
graphite-app
bot
deleted the
xp/03-20-fix_electron_optimize_electron_open_close_on_mac
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.