Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): add oauth connecting state #6225

Merged
merged 1 commit into from
Mar 23, 2024

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Mar 20, 2024

No description provided.

Copy link

nx-cloud bot commented Mar 20, 2024

@fundon fundon requested a review from forehalo March 20, 2024 07:50
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.77%. Comparing base (4f59077) to head (b423773).

❗ Current head b423773 differs from pull request most recent head 0d652a0. Consider uploading reports for the commit 0d652a0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6225      +/-   ##
==========================================
- Coverage   60.85%   60.77%   -0.09%     
==========================================
  Files         508      508              
  Lines       22964    22963       -1     
  Branches     2076     2075       -1     
==========================================
- Hits        13975    13956      -19     
- Misses       8737     8754      +17     
- Partials      252      253       +1     
Flag Coverage Δ
server-test 70.83% <ø> (-0.12%) ⬇️
unittest 39.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fundon fundon marked this pull request as draft March 20, 2024 07:54
@fundon fundon changed the title chore: add oauth connecting state on web chore: add oauth connecting state Mar 20, 2024
@fundon fundon marked this pull request as ready for review March 20, 2024 08:02
Copy link

graphite-app bot commented Mar 20, 2024

Merge activity

@Brooooooklyn Brooooooklyn changed the title chore: add oauth connecting state chore(core): add oauth connecting state Mar 21, 2024
@EYHN EYHN merged commit 6c9db36 into toeverything:canary Mar 23, 2024
33 of 35 checks passed
@fundon fundon deleted the chore-oauth-signin-status branch March 23, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants