Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add page group and display properties #6228

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented Mar 20, 2024

close TOV-23

2024-03-22.12.04.12.mov

Copy link

graphite-app bot commented Mar 20, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Member Author

JimmFly commented Mar 20, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JimmFly and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Mar 20, 2024

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.04%. Comparing base (6467e10) to head (1ff6af8).

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #6228   +/-   ##
=======================================
  Coverage   60.04%   60.04%           
=======================================
  Files         509      509           
  Lines       23512    23512           
  Branches     2150     2150           
=======================================
  Hits        14117    14117           
  Misses       9134     9134           
  Partials      261      261           
Flag Coverage Δ
server-test 70.43% <ø> (ø)
unittest 38.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the mod:i18n Related to i18n label Mar 21, 2024
@JimmFly JimmFly force-pushed the jimmfly/0320/group branch 3 times, most recently from 892d99a to 60bdd45 Compare March 22, 2024 03:30
@JimmFly JimmFly changed the title feat(core): add page group feat(core): add page group and display properties Mar 22, 2024
@JimmFly JimmFly marked this pull request as ready for review March 22, 2024 03:54
@github-actions github-actions bot added the test Related to test cases label Mar 22, 2024
@JimmFly JimmFly requested review from EYHN and pengx17 March 22, 2024 04:10
Copy link
Collaborator

@pengx17 pengx17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some new e2e tests for grouping & display properties

@JimmFly JimmFly requested a review from pengx17 March 22, 2024 07:23
@JimmFly JimmFly force-pushed the jimmfly/0320/group branch 2 times, most recently from d06c70d to bbf5995 Compare March 25, 2024 06:01
Copy link

graphite-app bot commented Mar 25, 2024

Merge activity

@graphite-app graphite-app bot merged commit 1ff6af8 into canary Mar 25, 2024
41 checks passed
@graphite-app graphite-app bot deleted the jimmfly/0320/group branch March 25, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:i18n Related to i18n test Related to test cases
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants