Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: open about page in setting modal when click about menu #6245

Conversation

BABA983
Copy link
Contributor

@BABA983 BABA983 commented Mar 21, 2024

For #6195

@CLAassistant
Copy link

CLAassistant commented Mar 21, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added app:electron Related to electron app app:core labels Mar 21, 2024
@EYHN EYHN requested a review from pengx17 March 21, 2024 08:26
Copy link

nx-cloud bot commented Mar 21, 2024

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.13%. Comparing base (3c6983e) to head (c5fd53e).
Report is 5 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6245      +/-   ##
==========================================
- Coverage   60.14%   60.13%   -0.01%     
==========================================
  Files         506      507       +1     
  Lines       23495    23493       -2     
  Branches     2150     2151       +1     
==========================================
- Hits        14131    14128       -3     
+ Misses       9106     9104       -2     
- Partials      258      261       +3     
Flag Coverage Δ
server-test 70.57% <ø> (-0.01%) ⬇️
unittest 38.60% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 changed the title Open about page in setting modal when click about menu feat: Open about page in setting modal when click about menu Mar 21, 2024
@pengx17 pengx17 changed the title feat: Open about page in setting modal when click about menu feat: open about page in setting modal when click about menu Mar 21, 2024
@EYHN EYHN enabled auto-merge (squash) March 23, 2024 12:11
@EYHN EYHN disabled auto-merge March 23, 2024 12:11
@EYHN EYHN enabled auto-merge (squash) March 23, 2024 13:19
@EYHN EYHN merged commit 6a02d0b into toeverything:canary Mar 23, 2024
32 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core app:electron Related to electron app
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants