-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): refactor sidebar header #6251
Conversation
CatsJuice
commented
Mar 21, 2024
•
edited
edited
- Add user avatar
- Move sign-out/user settings link from workspace-modal to user avatar modal
- Modify the style of workspace list items
- Modify gap of navigation buttons
- Animate Syncing/Offline/...
Your org has enabled the Graphite merge queue for merging into canaryYou must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. You can enable merging using labels in your Graphite merge queue settings. |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @CatsJuice and the rest of your teammates on Graphite |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 0731872. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## canary #6251 +/- ##
==========================================
+ Coverage 62.33% 62.39% +0.05%
==========================================
Files 510 510
Lines 23550 23531 -19
Branches 2217 2215 -2
==========================================
Hits 14681 14681
+ Misses 8608 8589 -19
Partials 261 261
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ba050ab
to
a0e5857
Compare
556cd28
to
8fa156f
Compare
b7e7816
to
02691f2
Compare
Actually, I think so too, but this is how it's designed now. cc @zanwei |
This thing rotates on reload. Is this expected? Kapture.2024-03-25.at.15.05.37.mp4 |
Looks like we no longer requires emotion after this pr. Maybe we can finally remove it completely |
Oh, not expected. Local workspace shouldn't have sync status. |
I'm afraid there still be a lot of |
packages/frontend/core/src/components/pure/workspace-slider-bar/workspace-card/index.tsx
Outdated
Show resolved
Hide resolved
729f3f4
to
5b96f06
Compare
Feedback received. We might need to change the click area to full width. Th cc @CatsJuice |
Merge activity
|
- Add user avatar - Move sign-out/user settings link from workspace-modal to user avatar modal - Modify the style of workspace list items - Modify gap of navigation buttons - Animate Syncing/Offline/... ![CleanShot 2024-03-22 at 10.22.38.gif](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/LakojjjzZNf6ogjOVwKE/7305f561-a85b-4ec6-89c2-27e2f1b63c85.gif)
4b764f7
to
0731872
Compare
One more thing needs to be change that adjust the portrait size from 20px to 24px, thanks! cc @CatsJuice |