Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): refactor sidebar header #6251

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

CatsJuice
Copy link
Member

@CatsJuice CatsJuice commented Mar 21, 2024

  • Add user avatar
  • Move sign-out/user settings link from workspace-modal to user avatar modal
  • Modify the style of workspace list items
  • Modify gap of navigation buttons
  • Animate Syncing/Offline/...

CleanShot 2024-03-22 at 10.22.38.gif

Copy link

graphite-app bot commented Mar 21, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CatsJuice and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Mar 21, 2024

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 62.39%. Comparing base (d8a3cd5) to head (0731872).

Files Patch % Lines
...pure/workspace-slider-bar/workspace-card/index.tsx 20.00% 8 Missing ⚠️
...onent/src/components/card/workspace-card/index.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6251      +/-   ##
==========================================
+ Coverage   62.33%   62.39%   +0.05%     
==========================================
  Files         510      510              
  Lines       23550    23531      -19     
  Branches     2217     2215       -2     
==========================================
  Hits        14681    14681              
+ Misses       8608     8589      -19     
  Partials      261      261              
Flag Coverage Δ
server-test 73.82% <ø> (ø)
unittest 38.78% <66.66%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CatsJuice CatsJuice force-pushed the catsjuice/feat/sidebar-userinfo branch from ba050ab to a0e5857 Compare March 21, 2024 08:45
@CatsJuice CatsJuice marked this pull request as ready for review March 21, 2024 12:05
@CatsJuice CatsJuice force-pushed the catsjuice/feat/sidebar-userinfo branch 2 times, most recently from 556cd28 to 8fa156f Compare March 23, 2024 14:42
@github-actions github-actions bot added mod:infra Environment related issues and discussions docs Improvements or additions to documentation mod:store app:server test Related to test cases labels Mar 23, 2024
@CatsJuice CatsJuice force-pushed the catsjuice/feat/sidebar-userinfo branch 3 times, most recently from b7e7816 to 02691f2 Compare March 25, 2024 06:40
@JimmFly
Copy link
Member

JimmFly commented Mar 25, 2024

Do we require a larger clickable area?
For instance, transitioning from a red zone to a green zone.
image

@CatsJuice
Copy link
Member Author

Do we require a larger clickable area? For instance, transitioning from a red zone to a green zone. image

Actually, I think so too, but this is how it's designed now. cc @zanwei

@pengx17
Copy link
Collaborator

pengx17 commented Mar 25, 2024

image The clicking area is determined by workspace name length, which is weird.

@pengx17
Copy link
Collaborator

pengx17 commented Mar 25, 2024

This thing rotates on reload. Is this expected?

Kapture.2024-03-25.at.15.05.37.mp4

@pengx17
Copy link
Collaborator

pengx17 commented Mar 25, 2024

Looks like we no longer requires emotion after this pr. Maybe we can finally remove it completely

@CatsJuice
Copy link
Member Author

This thing rotates on reload. Is this expected?

Kapture.2024-03-25.at.15.05.37.mp4

Oh, not expected. Local workspace shouldn't have sync status.

@CatsJuice
Copy link
Member Author

Looks like we no longer requires emotion after this pr. Maybe we can finally remove it completely

I'm afraid there still be a lot of styled used

@CatsJuice CatsJuice force-pushed the catsjuice/feat/sidebar-userinfo branch from 729f3f4 to 5b96f06 Compare March 26, 2024 01:17
@zanwei
Copy link
Member

zanwei commented Mar 26, 2024

Feedback received. We might need to change the click area to full width. Th

cc @CatsJuice

image

Copy link

graphite-app bot commented Mar 26, 2024

Merge activity

- Add user avatar
- Move sign-out/user settings link from workspace-modal to user avatar modal
- Modify the style of workspace list items
- Modify gap of navigation buttons
- Animate Syncing/Offline/...

![CleanShot 2024-03-22 at 10.22.38.gif](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/LakojjjzZNf6ogjOVwKE/7305f561-a85b-4ec6-89c2-27e2f1b63c85.gif)
@Brooooooklyn Brooooooklyn force-pushed the catsjuice/feat/sidebar-userinfo branch from 4b764f7 to 0731872 Compare March 26, 2024 06:10
@graphite-app graphite-app bot merged commit 0731872 into canary Mar 26, 2024
38 of 40 checks passed
@graphite-app graphite-app bot deleted the catsjuice/feat/sidebar-userinfo branch March 26, 2024 06:23
@zanwei
Copy link
Member

zanwei commented Mar 26, 2024

One more thing needs to be change that adjust the portrait size from 20px to 24px, thanks!

cc @CatsJuice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core app:server docs Improvements or additions to documentation mod:component mod:infra Environment related issues and discussions mod:store test Related to test cases
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants