Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(electron): linux crash on exiting presentation mode #6253

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Mar 21, 2024

No description provided.

Copy link

graphite-app bot commented Mar 21, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Collaborator Author

pengx17 commented Mar 21, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the app:electron Related to electron app label Mar 21, 2024
@pengx17 pengx17 requested review from CatsJuice and EYHN March 21, 2024 09:17
@pengx17 pengx17 marked this pull request as ready for review March 21, 2024 09:17
Copy link

nx-cloud bot commented Mar 21, 2024

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.77%. Comparing base (6a0ab54) to head (d03c72a).

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6253      +/-   ##
==========================================
- Coverage   60.85%   60.77%   -0.09%     
==========================================
  Files         507      508       +1     
  Lines       22963    22964       +1     
  Branches     2076     2075       -1     
==========================================
- Hits        13974    13956      -18     
- Misses       8736     8755      +19     
  Partials      253      253              
Flag Coverage Δ
server-test 70.83% <ø> (-0.12%) ⬇️
unittest 39.02% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Mar 21, 2024

Merge activity

@EYHN EYHN force-pushed the 03-21-fix_electron_linux_crash_on_exiting_presentation_mode branch from 65c3124 to d03c72a Compare March 21, 2024 09:55
@graphite-app graphite-app bot merged commit d03c72a into canary Mar 21, 2024
39 of 41 checks passed
@graphite-app graphite-app bot deleted the 03-21-fix_electron_linux_crash_on_exiting_presentation_mode branch March 21, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:electron Related to electron app
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants