Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve password error message #6255

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Mar 21, 2024

chore: improve error message

chore: add password minlength & maxlength i18n

chore: check max length

fix: i18n variables

feat: add CredentialsRequirementType

Copy link

graphite-app bot commented Mar 21, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Contributor Author

fundon commented Mar 21, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fundon and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Mar 21, 2024

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 89.18919% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 62.45%. Comparing base (b8e6d7d) to head (8ee9f6e).

Files Patch % Lines
...rontend/core/src/hooks/affine/use-server-config.ts 20.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6255      +/-   ##
==========================================
+ Coverage   62.42%   62.45%   +0.03%     
==========================================
  Files         510      510              
  Lines       23545    23579      +34     
  Branches     2220     2222       +2     
==========================================
+ Hits        14698    14727      +29     
- Misses       8587     8591       +4     
- Partials      260      261       +1     
Flag Coverage Δ
server-test 73.90% <100.00%> (+0.03%) ⬆️
unittest 38.79% <42.85%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fundon fundon force-pushed the improve-set-password-ui branch 9 times, most recently from 8212346 to f404e13 Compare March 22, 2024 09:43
@fundon fundon marked this pull request as ready for review March 22, 2024 09:44
@fundon fundon requested review from forehalo, darkskygit, CatsJuice and EYHN and removed request for forehalo and darkskygit March 22, 2024 09:44
@fundon fundon changed the title chore: improve error message chore: improve password error message Mar 22, 2024
@fundon fundon force-pushed the improve-set-password-ui branch 5 times, most recently from 5590da7 to 4db1bf3 Compare March 23, 2024 14:06
@fundon fundon force-pushed the improve-set-password-ui branch 2 times, most recently from 2e2730f to c7ecb19 Compare March 25, 2024 06:50
@fundon fundon force-pushed the improve-set-password-ui branch 6 times, most recently from a426438 to 2f59cef Compare March 25, 2024 09:50
@fundon fundon force-pushed the improve-set-password-ui branch 2 times, most recently from 62ddaa6 to 43d9c7b Compare March 25, 2024 11:14
@fundon fundon marked this pull request as draft March 25, 2024 11:28
@fundon fundon force-pushed the improve-set-password-ui branch 2 times, most recently from 3f9412b to e040e58 Compare March 25, 2024 12:58
@fundon fundon marked this pull request as ready for review March 25, 2024 12:59
Copy link

graphite-app bot commented Mar 26, 2024

Merge activity

chore: improve error message

chore: add password minlength & maxlength i18n

chore: check max length

fix: i18n variables

feat: add CredentialsRequirementType
@graphite-app graphite-app bot merged commit 8ee9f6e into canary Mar 26, 2024
40 of 41 checks passed
@graphite-app graphite-app bot deleted the improve-set-password-ui branch March 26, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants