Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(electron): add icon for AppImage build #6257

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Mar 21, 2024

  1. the icon is fixed in /Applications: toeverything/electron-forge-maker-appimage@128b8c2#diff-a694a3e854f53b066e34ec310e05bd18b4944c016455f6963f54a351784d5fa6L91
  2. the App's icon MUST be 64x64 png and set via setIcon

image

Copy link

graphite-app bot commented Mar 21, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Collaborator Author

pengx17 commented Mar 21, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the app:electron Related to electron app label Mar 21, 2024
Copy link

nx-cloud bot commented Mar 21, 2024

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.77%. Comparing base (540e456) to head (85ee223).

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #6257   +/-   ##
=======================================
  Coverage   60.77%   60.77%           
=======================================
  Files         508      509    +1     
  Lines       22965    22966    +1     
  Branches     2075     2075           
=======================================
+ Hits        13957    13958    +1     
  Misses       8755     8755           
  Partials      253      253           
Flag Coverage Δ
server-test 70.83% <ø> (ø)
unittest 39.03% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 marked this pull request as ready for review March 21, 2024 11:33
@pengx17 pengx17 force-pushed the 03-21-fix_electron_add_icon_for_appimage_build branch from aa64c6f to fa11a3d Compare March 21, 2024 11:36
@pengx17 pengx17 force-pushed the 03-21-fix_electron_add_icon_for_appimage_build branch from fa11a3d to 4dcbc93 Compare March 21, 2024 13:28
@pengx17
Copy link
Collaborator Author

pengx17 commented Mar 21, 2024

can you please check the license compliance issue? @Brooooooklyn

Copy link

graphite-app bot commented Mar 21, 2024

Merge activity

@Brooooooklyn Brooooooklyn force-pushed the 03-21-fix_electron_add_icon_for_appimage_build branch from 4dcbc93 to 85ee223 Compare March 21, 2024 14:29
@graphite-app graphite-app bot merged commit 85ee223 into canary Mar 21, 2024
38 of 41 checks passed
@graphite-app graphite-app bot deleted the 03-21-fix_electron_add_icon_for_appimage_build branch March 21, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:electron Related to electron app
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants