-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(electron): add icon for AppImage build #6257
fix(electron): add icon for AppImage build #6257
Conversation
Your org has enabled the Graphite merge queue for merging into canaryYou must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. You can enable merging using labels in your Graphite merge queue settings. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 85ee223. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## canary #6257 +/- ##
=======================================
Coverage 60.77% 60.77%
=======================================
Files 508 509 +1
Lines 22965 22966 +1
Branches 2075 2075
=======================================
+ Hits 13957 13958 +1
Misses 8755 8755
Partials 253 253
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
aa64c6f
to
fa11a3d
Compare
fa11a3d
to
4dcbc93
Compare
can you please check the license compliance issue? @Brooooooklyn |
Merge activity
|
1. the icon is fixed in `/Applications`: toeverything/electron-forge-maker-appimage@128b8c2#diff-a694a3e854f53b066e34ec310e05bd18b4944c016455f6963f54a351784d5fa6L91 2. the App's icon MUST be 64x64 png and set via `setIcon` ![image](https://github.com/toeverything/AFFiNE/assets/584378/bbce0007-066b-413f-a85a-193acbbe5c13)
4dcbc93
to
85ee223
Compare
/Applications
: toeverything/electron-forge-maker-appimage@128b8c2#diff-a694a3e854f53b066e34ec310e05bd18b4944c016455f6963f54a351784d5fa6L91setIcon