Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): do not ensure properties on read #6263

Merged

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Mar 22, 2024

No description provided.

Copy link

graphite-app bot commented Mar 22, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Collaborator Author

pengx17 commented Mar 22, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Mar 22, 2024

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 60.13%. Comparing base (532d655) to head (62a6075).

Files Patch % Lines
...d/core/src/modules/workspace/properties/adapter.ts 57.14% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6263      +/-   ##
==========================================
+ Coverage   60.05%   60.13%   +0.07%     
==========================================
  Files         507      507              
  Lines       23509    23493      -16     
  Branches     2152     2151       -1     
==========================================
+ Hits        14119    14128       +9     
+ Misses       9132     9104      -28     
- Partials      258      261       +3     
Flag Coverage Δ
server-test 70.57% <ø> (+0.10%) ⬆️
unittest 38.60% <57.14%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 requested a review from EYHN March 22, 2024 03:38
@pengx17 pengx17 marked this pull request as ready for review March 22, 2024 03:38
Copy link

graphite-app bot commented Mar 23, 2024

Merge activity

@EYHN EYHN force-pushed the 03-13-fix_core_do_not_ensure_properties_on_read branch from 2115df8 to 62a6075 Compare March 23, 2024 12:15
@graphite-app graphite-app bot merged commit 62a6075 into canary Mar 23, 2024
38 of 40 checks passed
@graphite-app graphite-app bot deleted the 03-13-fix_core_do_not_ensure_properties_on_read branch March 23, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants