Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add confirm modal for delete tag action #6268

Merged
merged 1 commit into from
Mar 23, 2024

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented Mar 22, 2024

No description provided.

Copy link

graphite-app bot commented Mar 22, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Member Author

JimmFly commented Mar 22, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JimmFly and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added mod:i18n Related to i18n app:core labels Mar 22, 2024
Copy link

nx-cloud bot commented Mar 22, 2024

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 7.14286% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 60.00%. Comparing base (3c6983e) to head (532d655).

Files Patch % Lines
...end/core/src/modules/tag/view/delete-tag-modal.tsx 7.14% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6268      +/-   ##
==========================================
- Coverage   60.14%   60.00%   -0.14%     
==========================================
  Files         506      507       +1     
  Lines       23495    23509      +14     
  Branches     2150     2152       +2     
==========================================
- Hits        14131    14107      -24     
- Misses       9106     9144      +38     
  Partials      258      258              
Flag Coverage Δ
server-test 70.46% <ø> (-0.12%) ⬇️
unittest 38.47% <7.14%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Mar 23, 2024

Merge activity

@graphite-app graphite-app bot merged commit 532d655 into canary Mar 23, 2024
39 of 41 checks passed
@graphite-app graphite-app bot deleted the jimmfly/0322/confirm branch March 23, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:i18n Related to i18n
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants