Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): storybook build issue #6274

Merged
merged 1 commit into from
Mar 23, 2024

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Mar 23, 2024

  1. es2022 is required and should be set separately in storybook.
  2. @blocksuite/icons versions are not consistent across packages.

Copy link

graphite-app bot commented Mar 23, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Collaborator Author

pengx17 commented Mar 23, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added mod:component test Related to test cases labels Mar 23, 2024
Copy link

nx-cloud bot commented Mar 23, 2024

@pengx17 pengx17 requested a review from EYHN March 23, 2024 02:22
@pengx17 pengx17 marked this pull request as ready for review March 23, 2024 02:22
Copy link

codecov bot commented Mar 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.11%. Comparing base (34703a3) to head (3c6983e).

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6274      +/-   ##
==========================================
- Coverage   60.11%   60.11%   -0.01%     
==========================================
  Files         506      506              
  Lines       23495    23495              
  Branches     2150     2150              
==========================================
- Hits        14124    14123       -1     
- Misses       9112     9113       +1     
  Partials      259      259              
Flag Coverage Δ
server-test 70.57% <ø> (ø)
unittest 38.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 force-pushed the xp/03-23-fix_core_storybook_build_issue branch 2 times, most recently from 96d2eef to d6a8be5 Compare March 23, 2024 02:55
Copy link

graphite-app bot commented Mar 23, 2024

Merge activity

  • Mar 23, 2:32 AM EDT: Brooooooklyn added this pull request to the Graphite merge queue.
  • Mar 23, 2:44 AM EDT: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: '3, 2, 1 Launch', 'Server E2E Test 3/3').
  • Mar 23, 7:58 AM EDT: EYHN added this pull request to the Graphite merge queue.
  • Mar 23, 7:59 AM EDT: EYHN merged this pull request with the Graphite merge queue.

1. es2022 is required and should be set separately in storybook.
2. @blocksuite/icons versions are not consistent across packages.
@Brooooooklyn Brooooooklyn force-pushed the xp/03-23-fix_core_storybook_build_issue branch from d6a8be5 to 3c6983e Compare March 23, 2024 06:33
@graphite-app graphite-app bot merged commit 3c6983e into canary Mar 23, 2024
36 of 40 checks passed
@graphite-app graphite-app bot deleted the xp/03-23-fix_core_storybook_build_issue branch March 23, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mod:component test Related to test cases
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants