Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): image preview flaky #6292

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Mar 25, 2024

No description provided.

Copy link

graphite-app bot commented Mar 25, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

@pengx17 pengx17 requested review from CatsJuice and EYHN March 25, 2024 02:34
Copy link
Collaborator Author

pengx17 commented Mar 25, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the test Related to test cases label Mar 25, 2024
@pengx17 pengx17 marked this pull request as ready for review March 25, 2024 02:34
Copy link

nx-cloud bot commented Mar 25, 2024

@pengx17 pengx17 changed the title fix(test): image preview flaky fix(core): image preview flaky Mar 25, 2024
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.05%. Comparing base (64c011c) to head (578d4c9).

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6292      +/-   ##
==========================================
- Coverage   60.13%   60.05%   -0.09%     
==========================================
  Files         507      507              
  Lines       23496    23496              
  Branches     2151     2150       -1     
==========================================
- Hits        14129    14110      -19     
- Misses       9106     9125      +19     
  Partials      261      261              
Flag Coverage Δ
server-test 70.45% <ø> (-0.12%) ⬇️
unittest 38.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Mar 25, 2024

Merge activity

@EYHN EYHN force-pushed the xp/03-25-fix_test_image_preview_flaky branch from 13936db to 578d4c9 Compare March 25, 2024 02:46
@graphite-app graphite-app bot merged commit 578d4c9 into canary Mar 25, 2024
38 of 40 checks passed
@graphite-app graphite-app bot deleted the xp/03-25-fix_test_image_preview_flaky branch March 25, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Related to test cases
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants