Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: runtime issue for electron app #6306

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Mar 25, 2024

Looks like we need to be careful to share common libraries between electron (nodejs) & web

image.png

@pengx17 pengx17 marked this pull request as ready for review March 25, 2024 17:15
Copy link
Collaborator Author

pengx17 commented Mar 25, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

Copy link

graphite-app bot commented Mar 25, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

@github-actions github-actions bot added mod:infra Environment related issues and discussions app:electron Related to electron app labels Mar 25, 2024
Copy link

nx-cloud bot commented Mar 25, 2024

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.11%. Comparing base (00092c9) to head (1c9d899).

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6306      +/-   ##
==========================================
+ Coverage   60.04%   60.11%   +0.07%     
==========================================
  Files         509      509              
  Lines       23512    23512              
  Branches     2149     2150       +1     
==========================================
+ Hits        14117    14135      +18     
+ Misses       9134     9116      -18     
  Partials      261      261              
Flag Coverage Δ
server-test 70.54% <ø> (+0.11%) ⬆️
unittest 38.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 force-pushed the 03-26-fix_runtime_issue_for_electron_app branch from dc08bc5 to 582acc0 Compare March 25, 2024 17:22
Copy link

graphite-app bot commented Mar 26, 2024

Merge activity

@EYHN EYHN force-pushed the 03-26-fix_runtime_issue_for_electron_app branch from 582acc0 to 1c9d899 Compare March 26, 2024 02:04
@graphite-app graphite-app bot merged commit 1c9d899 into canary Mar 26, 2024
38 of 40 checks passed
@graphite-app graphite-app bot deleted the 03-26-fix_runtime_issue_for_electron_app branch March 26, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:electron Related to electron app mod:infra Environment related issues and discussions
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants