Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(electron): possible issue on openning two main windows #6307

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Mar 26, 2024

fix #6303

fetching getWindowAdditionalArguments requires forking a new process & handshake, which could be time consuming

Copy link

graphite-app bot commented Mar 26, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Collaborator Author

pengx17 commented Mar 26, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the app:electron Related to electron app label Mar 26, 2024
@pengx17 pengx17 marked this pull request as ready for review March 26, 2024 02:16
@pengx17 pengx17 requested a review from EYHN March 26, 2024 02:16
Copy link

nx-cloud bot commented Mar 26, 2024

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.33%. Comparing base (2662ba7) to head (e9bc24b).

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #6307   +/-   ##
=======================================
  Coverage   62.33%   62.33%           
=======================================
  Files         510      510           
  Lines       23550    23550           
  Branches     2217     2217           
=======================================
  Hits        14681    14681           
  Misses       8608     8608           
  Partials      261      261           
Flag Coverage Δ
server-test 73.82% <ø> (ø)
unittest 38.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Mar 26, 2024

Merge activity

fix #6303

fetching `getWindowAdditionalArguments` requires forking a new process & handshake, which could be time consuming
@Brooooooklyn Brooooooklyn force-pushed the xp/03-26-fix_electron_possible_issue_on_openning_two_main_windows branch from 4a9a483 to e9bc24b Compare March 26, 2024 03:29
@graphite-app graphite-app bot merged commit e9bc24b into canary Mar 26, 2024
38 of 39 checks passed
@graphite-app graphite-app bot deleted the xp/03-26-fix_electron_possible_issue_on_openning_two_main_windows branch March 26, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:electron Related to electron app
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

​Multiple windows will appear when click quickly on dock
2 participants