Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add shortcut for multi select docs #6318

Closed
wants to merge 1 commit into from

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented Mar 26, 2024

close TOV-701
In All Doc, Shift + Click has been added to activate the multiple selection state.

Copy link

graphite-app bot commented Mar 26, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Member Author

JimmFly commented Mar 26, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JimmFly and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Mar 26, 2024

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 61.80%. Comparing base (39facba) to head (273da3b).
Report is 35 commits behind head on canary.

Files Patch % Lines
...core/src/modules/workbench/view/workbench-link.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6318      +/-   ##
==========================================
- Coverage   62.54%   61.80%   -0.74%     
==========================================
  Files         510      515       +5     
  Lines       23602    24094     +492     
  Branches     2225     2344     +119     
==========================================
+ Hits        14762    14892     +130     
- Misses       8578     8936     +358     
- Partials      262      266       +4     
Flag Coverage Δ
server-test 74.02% <ø> (ø)
unittest 38.06% <0.00%> (-0.79%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the test Related to test cases label Mar 26, 2024
@JimmFly JimmFly requested review from pengx17 and EYHN March 26, 2024 07:41
@JimmFly JimmFly changed the title feat(core): adjust open tab shortcut and add shortcut for multi select docs feat(core): add shortcut for multi select docs Mar 27, 2024
@JimmFly JimmFly requested a review from pengx17 March 27, 2024 09:45
Copy link

graphite-app bot commented Mar 29, 2024

Merge activity

  • Mar 28, 9:40 PM EDT: pengx17 added this pull request to the Graphite merge queue.
  • Mar 28, 9:40 PM EDT: CI is running for this PR on a draft PR: #6376
  • Mar 28, 9:51 PM EDT: pengx17 merged this pull request with the Graphite merge queue via draft PR: #6376.

pengx17 pushed a commit that referenced this pull request Mar 29, 2024
close TOV-701
In All Doc, `Shift + Click` has been added to activate the multiple selection state.
@graphite-app graphite-app bot closed this Mar 29, 2024
@graphite-app graphite-app bot deleted the jimmfly/0326/shortcut branch March 29, 2024 01:51
@JimmFly JimmFly restored the jimmfly/0326/shortcut branch April 1, 2024 07:12
@JimmFly JimmFly reopened this Apr 1, 2024
@JimmFly JimmFly closed this Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core test Related to test cases
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants