Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(infra): large page list performance #6319

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Mar 26, 2024

No description provided.

Copy link

graphite-app bot commented Mar 26, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

@EYHN EYHN marked this pull request as ready for review March 26, 2024 07:42
Copy link
Member Author

EYHN commented Mar 26, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @EYHN and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the mod:infra Environment related issues and discussions label Mar 26, 2024
Copy link

nx-cloud bot commented Mar 26, 2024

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 62.45%. Comparing base (8ee9f6e) to head (b6bba52).

Files Patch % Lines
packages/common/infra/src/page/record-list.ts 75.00% 1 Missing and 1 partial ⚠️
packages/common/infra/src/page/record.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6319      +/-   ##
==========================================
- Coverage   62.53%   62.45%   -0.09%     
==========================================
  Files         510      510              
  Lines       23579    23587       +8     
  Branches     2223     2223              
==========================================
- Hits        14746    14732      -14     
- Misses       8572     8593      +21     
- Partials      261      262       +1     
Flag Coverage Δ
server-test 73.90% <ø> (-0.12%) ⬇️
unittest 38.81% <66.66%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Mar 26, 2024

Merge activity

@EYHN EYHN force-pushed the eyhn/fix/large-page-list-performance branch from 3fc028a to b6bba52 Compare March 26, 2024 07:54
@graphite-app graphite-app bot merged commit b6bba52 into canary Mar 26, 2024
39 of 40 checks passed
@graphite-app graphite-app bot deleted the eyhn/fix/large-page-list-performance branch March 26, 2024 08:04
@EYHN EYHN mentioned this pull request Mar 26, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mod:infra Environment related issues and discussions
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants