Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix meta.xxx is undefined #6321

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Mar 26, 2024

No description provided.

Copy link

graphite-app bot commented Mar 26, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

@EYHN EYHN marked this pull request as ready for review March 26, 2024 08:26
Copy link
Member Author

EYHN commented Mar 26, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @EYHN and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added mod:infra Environment related issues and discussions app:core labels Mar 26, 2024
Copy link

nx-cloud bot commented Mar 26, 2024

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 38.79%. Comparing base (b6bba52) to head (1606334).

Files Patch % Lines
...ages/frontend/core/src/modules/tag/entities/tag.ts 0.00% 3 Missing ⚠️
packages/common/infra/src/page/record.ts 50.00% 1 Missing ⚠️
...kages/frontend/core/src/modules/tag/service/tag.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           canary    #6321       +/-   ##
===========================================
- Coverage   62.53%   38.79%   -23.74%     
===========================================
  Files         510      357      -153     
  Lines       23587     7696    -15891     
  Branches     2224     1328      -896     
===========================================
- Hits        14751     2986    -11765     
+ Misses       8574     4481     -4093     
+ Partials      262      229       -33     
Flag Coverage Δ
server-test ?
unittest 38.79% <16.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Mar 26, 2024

Merge activity

@graphite-app graphite-app bot merged commit 1606334 into canary Mar 26, 2024
39 of 40 checks passed
@graphite-app graphite-app bot deleted the eyhn/fix/meta-missing branch March 26, 2024 09:03
@lawvs lawvs mentioned this pull request Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:infra Environment related issues and discussions
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants