Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): optimize sidebar workspace card and avatar #6324

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

CatsJuice
Copy link
Member

@CatsJuice CatsJuice commented Mar 26, 2024

  • adjust avatar size
  • unlogged avatar dark-mode
  • fix Tooltip console error
  • optimize syncing status animation

Copy link

graphite-app bot commented Mar 26, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CatsJuice and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Mar 26, 2024

@CatsJuice CatsJuice marked this pull request as ready for review March 26, 2024 09:06
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 9.09091% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 62.43%. Comparing base (cccf864) to head (a3cc06f).

Files Patch % Lines
...pure/workspace-slider-bar/workspace-card/index.tsx 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6324      +/-   ##
==========================================
- Coverage   62.45%   62.43%   -0.03%     
==========================================
  Files         510      510              
  Lines       23593    23601       +8     
  Branches     2223     2224       +1     
==========================================
  Hits        14736    14736              
- Misses       8595     8603       +8     
  Partials      262      262              
Flag Coverage Δ
server-test 73.91% <ø> (ø)
unittest 38.75% <9.09%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CatsJuice CatsJuice force-pushed the catsjuice/20230326/sidebar-optimization-patch branch from 713e656 to 98f4b32 Compare March 27, 2024 02:59
Copy link

graphite-app bot commented Mar 27, 2024

Merge activity

- adjust avatar size
- unlogged avatar dark-mode
- fix Tooltip console error
- optimize syncing status animation
@Brooooooklyn Brooooooklyn force-pushed the catsjuice/20230326/sidebar-optimization-patch branch from 98f4b32 to a3cc06f Compare March 27, 2024 03:29
@graphite-app graphite-app bot merged commit a3cc06f into canary Mar 27, 2024
36 of 40 checks passed
@graphite-app graphite-app bot deleted the catsjuice/20230326/sidebar-optimization-patch branch March 27, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants