Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): editor pgup/pgdn issues #6331

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Mar 26, 2024

fix #6232

Copy link
Collaborator Author

pengx17 commented Mar 26, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Mar 26, 2024

@pengx17 pengx17 marked this pull request as ready for review March 26, 2024 14:28
@pengx17 pengx17 requested review from CatsJuice and EYHN March 26, 2024 14:28
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.54%. Comparing base (5dcb3d6) to head (5ca17c1).

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6331      +/-   ##
==========================================
+ Coverage   62.46%   62.54%   +0.07%     
==========================================
  Files         510      510              
  Lines       23602    23602              
  Branches     2224     2225       +1     
==========================================
+ Hits        14743    14761      +18     
+ Misses       8597     8579      -18     
  Partials      262      262              
Flag Coverage Δ
server-test 74.02% <ø> (+0.11%) ⬆️
unittest 38.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Mar 27, 2024

Merge activity

@EYHN EYHN force-pushed the 03-26-fix_core_editor_pgup_pgdn_issues branch from b216da0 to 5ca17c1 Compare March 27, 2024 04:47
@graphite-app graphite-app bot merged commit 5ca17c1 into canary Mar 27, 2024
36 of 40 checks passed
@graphite-app graphite-app bot deleted the 03-26-fix_core_editor_pgup_pgdn_issues branch March 27, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

UI Bug when using PgUp or PgDown
2 participants