Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(infra): fix sqlite not save data #6336

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Mar 27, 2024

SQLiteDB will not save subdoc data that does not exist on rootdoc, so we must save rootdoc first, and then save subdoc

Copy link

graphite-app bot commented Mar 27, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Member Author

EYHN commented Mar 27, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @EYHN and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the mod:infra Environment related issues and discussions label Mar 27, 2024
@EYHN EYHN marked this pull request as ready for review March 27, 2024 04:14
Copy link

nx-cloud bot commented Mar 27, 2024

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.46%. Comparing base (a3cc06f) to head (30b8b12).

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6336      +/-   ##
==========================================
+ Coverage   62.43%   62.46%   +0.02%     
==========================================
  Files         510      510              
  Lines       23601    23602       +1     
  Branches     2224     2224              
==========================================
+ Hits        14736    14743       +7     
+ Misses       8603     8597       -6     
  Partials      262      262              
Flag Coverage Δ
server-test 73.91% <ø> (ø)
unittest 38.84% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Mar 27, 2024

Merge activity

SQLiteDB will not save subdoc data that does not exist on rootdoc, so we must save rootdoc first, and then save subdoc
@graphite-app graphite-app bot merged commit 30b8b12 into canary Mar 27, 2024
36 of 40 checks passed
@graphite-app graphite-app bot deleted the eyhn/fix/sqlite-sync branch March 27, 2024 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mod:infra Environment related issues and discussions
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants