Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use overflow: clip instead of js to prevent scrolling with pgup/pgdown #6338

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Mar 27, 2024

No description provided.

Copy link

graphite-app bot commented Mar 27, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

@pengx17 pengx17 marked this pull request as ready for review March 27, 2024 06:08
Copy link
Collaborator Author

pengx17 commented Mar 27, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Mar 27, 2024

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.46%. Comparing base (5ca17c1) to head (d4c7d58).

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6338      +/-   ##
==========================================
- Coverage   62.54%   62.46%   -0.08%     
==========================================
  Files         510      510              
  Lines       23602    23602              
  Branches     2225     2224       -1     
==========================================
- Hits        14761    14743      -18     
- Misses       8579     8597      +18     
  Partials      262      262              
Flag Coverage Δ
server-test 73.91% <ø> (-0.12%) ⬇️
unittest 38.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 requested review from CatsJuice and EYHN March 27, 2024 06:12
Copy link

graphite-app bot commented Mar 27, 2024

Merge activity

@Brooooooklyn Brooooooklyn force-pushed the 03-27-fix_use_overflow_clip_instead_of_js_to_prevent_scrolling_with_pgup_pgdown branch from e5a02d3 to d4c7d58 Compare March 27, 2024 07:07
@graphite-app graphite-app bot merged commit d4c7d58 into canary Mar 27, 2024
36 of 40 checks passed
@graphite-app graphite-app bot deleted the 03-27-fix_use_overflow_clip_instead_of_js_to_prevent_scrolling_with_pgup_pgdown branch March 27, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants