Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): open restore history confirm modal with hook #6343

Merged

Conversation

CatsJuice
Copy link
Member

No description provided.

Copy link

graphite-app bot commented Mar 27, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Member Author

CatsJuice commented Mar 27, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CatsJuice and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Mar 27, 2024

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.49%. Comparing base (d412635) to head (710edd2).

Additional details and impacted files
@@                               Coverage Diff                               @@
##           catsjuice/feat/show-confirm-modal-with-hook    #6343      +/-   ##
===============================================================================
+ Coverage                                        62.41%   62.49%   +0.07%     
===============================================================================
  Files                                              510      510              
  Lines                                            23626    23626              
  Branches                                          2226     2227       +1     
===============================================================================
+ Hits                                             14746    14764      +18     
+ Misses                                            8618     8600      -18     
  Partials                                           262      262              
Flag Coverage Δ
server-test 74.02% <ø> (+0.11%) ⬆️
unittest 38.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CatsJuice CatsJuice marked this pull request as ready for review March 27, 2024 09:14
@CatsJuice CatsJuice requested review from pengx17 and EYHN March 27, 2024 09:25
@CatsJuice CatsJuice force-pushed the catsjuice/replace-confirm-model-usage-with-hook branch 2 times, most recently from a80a618 to a214ddc Compare March 27, 2024 11:55
Copy link

graphite-app bot commented Mar 27, 2024

Merge activity

@EYHN EYHN force-pushed the catsjuice/feat/show-confirm-modal-with-hook branch from a03b750 to d412635 Compare March 27, 2024 13:30
@EYHN EYHN force-pushed the catsjuice/replace-confirm-model-usage-with-hook branch from a214ddc to 710edd2 Compare March 27, 2024 13:31
@EYHN EYHN changed the base branch from catsjuice/feat/show-confirm-modal-with-hook to canary March 27, 2024 13:42
@graphite-app graphite-app bot merged commit 710edd2 into canary Mar 27, 2024
32 checks passed
@graphite-app graphite-app bot deleted the catsjuice/replace-confirm-model-usage-with-hook branch March 27, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants