Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(infra): fix white screen issue #6350

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Mar 27, 2024

No description provided.

Copy link

graphite-app bot commented Mar 27, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Member Author

EYHN commented Mar 27, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @EYHN and the rest of your teammates on Graphite Graphite

@EYHN EYHN marked this pull request as ready for review March 27, 2024 15:42
@github-actions github-actions bot added the mod:infra Environment related issues and discussions label Mar 27, 2024
Copy link

nx-cloud bot commented Mar 27, 2024

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.48%. Comparing base (e24b6e4) to head (4e7652f).

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6350      +/-   ##
==========================================
+ Coverage   62.40%   62.48%   +0.07%     
==========================================
  Files         510      510              
  Lines       23630    23631       +1     
  Branches     2229     2230       +1     
==========================================
+ Hits        14746    14765      +19     
+ Misses       8621     8603      -18     
  Partials      263      263              
Flag Coverage Δ
server-test 74.02% <ø> (+0.11%) ⬆️
unittest 38.75% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@forehalo
Copy link
Member

should add some unit tests against the engine later on

Copy link

graphite-app bot commented Mar 28, 2024

Merge activity

@graphite-app graphite-app bot merged commit 4e7652f into canary Mar 28, 2024
36 of 40 checks passed
@graphite-app graphite-app bot deleted the eyhn/fix/white-screen branch March 28, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mod:infra Environment related issues and discussions
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants