Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should use fullscreen to control where to place macos window controls #6351

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Mar 27, 2024

No description provided.

Copy link

graphite-app bot commented Mar 27, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Collaborator Author

pengx17 commented Mar 27, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added app:electron Related to electron app app:core labels Mar 27, 2024
@pengx17 pengx17 marked this pull request as ready for review March 27, 2024 17:13
Copy link

nx-cloud bot commented Mar 27, 2024

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 62.38%. Comparing base (4e7652f) to head (e53744b).

Files Patch % Lines
...rc/components/pure/header/windows-app-controls.tsx 20.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6351      +/-   ##
==========================================
- Coverage   62.48%   62.38%   -0.10%     
==========================================
  Files         510      510              
  Lines       23631    23641      +10     
  Branches     2230     2231       +1     
==========================================
- Hits        14766    14749      -17     
- Misses       8602     8629      +27     
  Partials      263      263              
Flag Coverage Δ
server-test 73.91% <ø> (-0.12%) ⬇️
unittest 38.72% <20.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Mar 28, 2024

Merge activity

@Brooooooklyn Brooooooklyn force-pushed the 03-28-fix_should_use_fullscreen_to_control_where_to_place_macos_window_controls branch from 3e6e8ba to e53744b Compare March 28, 2024 03:40
@graphite-app graphite-app bot merged commit e53744b into canary Mar 28, 2024
36 of 40 checks passed
@graphite-app graphite-app bot deleted the 03-28-fix_should_use_fullscreen_to_control_where_to_place_macos_window_controls branch March 28, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core app:electron Related to electron app
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants