Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): sidebar local workspace enable cloud directly #6366

Closed

Conversation

CatsJuice
Copy link
Member

@CatsJuice CatsJuice commented Mar 28, 2024

  • Add a new hook useEnableClould, remove <EnableAffineClouldModal />
  • Sidebar local workspace list item support enable AFFiNE Cloud

Copy link

graphite-app bot commented Mar 28, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CatsJuice and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Mar 28, 2024

@CatsJuice CatsJuice marked this pull request as ready for review March 28, 2024 10:23
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 1.61290% with 61 lines in your changes are missing coverage. Please review.

Project coverage is 62.29%. Comparing base (1a873ec) to head (af3caf1).

Files Patch % Lines
...rontend/core/src/hooks/affine/use-enable-cloud.tsx 3.03% 32 Missing ⚠️
.../user-with-workspace-list/workspace-list/index.tsx 0.00% 16 Missing ⚠️
...onent/src/components/card/workspace-card/index.tsx 0.00% 7 Missing ⚠️
.../frontend/component/src/ui/modal/confirm-modal.tsx 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6366      +/-   ##
==========================================
- Coverage   62.38%   62.29%   -0.09%     
==========================================
  Files         510      513       +3     
  Lines       23644    23716      +72     
  Branches     2233     2246      +13     
==========================================
+ Hits        14750    14774      +24     
- Misses       8631     8679      +48     
  Partials      263      263              
Flag Coverage Δ
server-test 74.02% <ø> (+0.11%) ⬆️
unittest 38.44% <1.61%> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CatsJuice CatsJuice force-pushed the catsjuice/feat/sidebar-workspace-list-enable-cloud branch from 2d07862 to af3caf1 Compare March 29, 2024 01:57
Copy link

graphite-app bot commented Mar 29, 2024

Merge activity

  • Mar 28, 10:07 PM EDT: Brooooooklyn added this pull request to the Graphite merge queue.
  • Mar 28, 10:08 PM EDT: CI is running for this PR on a draft PR: #6377
  • Mar 28, 10:18 PM EDT: Brooooooklyn merged this pull request with the Graphite merge queue via draft PR: #6377.

Brooooooklyn pushed a commit that referenced this pull request Mar 29, 2024
- Add a new hook `useEnableClould`, remove `<EnableAffineClouldModal />`
- Sidebar local workspace list item support enable AFFiNE Cloud
@graphite-app graphite-app bot closed this Mar 29, 2024
@graphite-app graphite-app bot deleted the catsjuice/feat/sidebar-workspace-list-enable-cloud branch March 29, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants