Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade cmdk to 1.0.0 #6401

Merged
merged 1 commit into from Mar 30, 2024
Merged

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Mar 29, 2024

Also include the command score into our own repo for some tweaks.

Might fix #6322

Copy link

graphite-app bot commented Mar 29, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

Copy link
Collaborator Author

pengx17 commented Mar 29, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

@pengx17 pengx17 force-pushed the 03-29-chore_upgrade_cmdk_to_1.0.0 branch from fb335b7 to 460c808 Compare March 29, 2024 09:12
@github-actions github-actions bot added test Related to test cases app:core labels Mar 29, 2024
@pengx17 pengx17 marked this pull request as ready for review March 29, 2024 09:12
Copy link

nx-cloud bot commented Mar 29, 2024

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 95.23810% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 62.05%. Comparing base (822bbb5) to head (f41d587).

Files Patch % Lines
...end/core/src/components/pure/cmdk/command-score.ts 95.23% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6401      +/-   ##
==========================================
+ Coverage   61.96%   62.05%   +0.08%     
==========================================
  Files         514      515       +1     
  Lines       23815    23878      +63     
  Branches     2267     2285      +18     
==========================================
+ Hits        14758    14818      +60     
- Misses       8794     8795       +1     
- Partials      263      265       +2     
Flag Coverage Δ
server-test 73.91% <ø> (ø)
unittest 38.44% <95.23%> (+0.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 force-pushed the 03-29-chore_upgrade_cmdk_to_1.0.0 branch from 460c808 to ba84cb7 Compare March 29, 2024 10:14
Copy link

graphite-app bot commented Mar 30, 2024

Merge activity

Also include the command score into our own repo for some tweaks.

Might fix #6322
@Brooooooklyn Brooooooklyn force-pushed the 03-29-chore_upgrade_cmdk_to_1.0.0 branch from ba84cb7 to f41d587 Compare March 30, 2024 08:00
@graphite-app graphite-app bot merged commit f41d587 into canary Mar 30, 2024
36 of 40 checks passed
@graphite-app graphite-app bot deleted the 03-29-chore_upgrade_cmdk_to_1.0.0 branch March 30, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core test Related to test cases
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

​Slash Menu stuck
2 participants