Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: onboarding app should also setup app storage config #6427

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Apr 1, 2024

No description provided.

Copy link

graphite-app bot commented Apr 1, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

@pengx17 pengx17 marked this pull request as ready for review April 1, 2024 06:24
@github-actions github-actions bot added the app:electron Related to electron app label Apr 1, 2024
Copy link

nx-cloud bot commented Apr 1, 2024

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.37%. Comparing base (e33ab17) to head (23cb309).

Additional details and impacted files
@@             Coverage Diff             @@
##           canary    #6427       +/-   ##
===========================================
- Coverage   62.02%   38.37%   -23.65%     
===========================================
  Files         515      362      -153     
  Lines       23891     7994    -15897     
  Branches     2287     1392      -895     
===========================================
- Hits        14818     3068    -11750     
+ Misses       8808     4694     -4114     
+ Partials      265      232       -33     
Flag Coverage Δ
server-test ?
unittest 38.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Apr 1, 2024

Merge activity

@EYHN EYHN force-pushed the xp/04-01-fix_onboarding_app_should_also_setup_app_storage_config branch from 1a259c8 to 23cb309 Compare April 1, 2024 07:04
@graphite-app graphite-app bot merged commit 23cb309 into canary Apr 1, 2024
36 of 40 checks passed
@graphite-app graphite-app bot deleted the xp/04-01-fix_onboarding_app_should_also_setup_app_storage_config branch April 1, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:electron Related to electron app
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants