Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add favorite operation to all collection #6428

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented Apr 1, 2024

2024-04-01.2.45.44.mov

Copy link

graphite-app bot commented Apr 1, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

Copy link
Member Author

JimmFly commented Apr 1, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JimmFly and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Apr 1, 2024

@JimmFly JimmFly requested a review from pengx17 April 1, 2024 06:51
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.34%. Comparing base (381be8a) to head (4624a49).

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #6428   +/-   ##
=======================================
  Coverage   62.34%   62.34%           
=======================================
  Files         518      518           
  Lines       24013    24013           
  Branches     2266     2266           
=======================================
  Hits        14971    14971           
  Misses       8776     8776           
  Partials      266      266           
Flag Coverage Δ
server-test 73.86% <ø> (+11.52%) ⬆️
unittest 38.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Apr 2, 2024

Merge activity

@EYHN EYHN force-pushed the jimmfly/0401/collection-fav branch from 2497717 to 4624a49 Compare April 2, 2024 08:35
@graphite-app graphite-app bot merged commit 4624a49 into canary Apr 2, 2024
36 of 40 checks passed
@graphite-app graphite-app bot deleted the jimmfly/0401/collection-fav branch April 2, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants