Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(component): useConfirmModal can't be closed automatically when 'onConfirm' is non-async #6439

Merged
merged 1 commit into from Apr 2, 2024

Conversation

CatsJuice
Copy link
Member

No description provided.

Copy link

graphite-app bot commented Apr 2, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

@CatsJuice CatsJuice marked this pull request as ready for review April 2, 2024 03:35
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CatsJuice and the rest of your teammates on Graphite Graphite

@CatsJuice CatsJuice changed the title fix(component): useConfirmModal can't be closed automatically when 'onConfirm' is non-async. fix(components): useConfirmModal can't be closed automatically when 'onConfirm' is non-async. Apr 2, 2024
Copy link

nx-cloud bot commented Apr 2, 2024

@EYHN EYHN changed the title fix(components): useConfirmModal can't be closed automatically when 'onConfirm' is non-async. fix(ui): Enhance AutoClose Functionality in Confirm Modal Apr 2, 2024
@EYHN EYHN changed the title fix(ui): Enhance AutoClose Functionality in Confirm Modal fix(components): useConfirmModal can't be closed automatically when 'onConfirm' is non-async Apr 2, 2024
@EYHN EYHN changed the title fix(components): useConfirmModal can't be closed automatically when 'onConfirm' is non-async fix(component): useConfirmModal can't be closed automatically when 'onConfirm' is non-async Apr 2, 2024
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 62.34%. Comparing base (3c01d94) to head (381be8a).

Files Patch % Lines
.../frontend/component/src/ui/modal/confirm-modal.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #6439   +/-   ##
=======================================
  Coverage   62.34%   62.34%           
=======================================
  Files         518      518           
  Lines       24013    24013           
  Branches     2266     2266           
=======================================
  Hits        14971    14971           
  Misses       8776     8776           
  Partials      266      266           
Flag Coverage Δ
server-test 73.86% <ø> (ø)
unittest 38.73% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CatsJuice CatsJuice requested review from EYHN and JimmFly April 2, 2024 06:06
Copy link

graphite-app bot commented Apr 2, 2024

Merge activity

@EYHN EYHN force-pushed the catsjuice/fix/use-confirm-wont-auto-close branch from e48b5f2 to 381be8a Compare April 2, 2024 08:23
@graphite-app graphite-app bot merged commit 381be8a into canary Apr 2, 2024
36 of 40 checks passed
@graphite-app graphite-app bot deleted the catsjuice/fix/use-confirm-wont-auto-close branch April 2, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants