Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): viewport element not found in share page #6453

Merged
merged 2 commits into from Apr 10, 2024

Conversation

L-Sun
Copy link
Contributor

@L-Sun L-Sun commented Apr 3, 2024

image

It seems that the className in these two pieces of code needs to be consistent because BlockSuite requires '.affine-page-viewport' to locate the viewport. But I cannot confirm wheter styles.affineDocViewport to be added to share-detail-page

<Scrollable.Viewport
className={clsx(
'affine-page-viewport',
styles.affineDocViewport,
styles.editorContainer
)}
>
<PageDetailEditor

<Scrollable.Viewport className={styles.editorContainer}>
<PageDetailEditor
isPublic
publishMode={publishMode}
docCollection={page.blockSuiteDoc.collection}
pageId={page.id}
onLoad={onEditorLoad}
/>

Copy link

nx-cloud bot commented Apr 3, 2024

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.39%. Comparing base (e7de20f) to head (ad842d0).
Report is 3 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6453      +/-   ##
==========================================
- Coverage   62.41%   62.39%   -0.02%     
==========================================
  Files         518      519       +1     
  Lines       24012    24016       +4     
  Branches     2268     2268              
==========================================
- Hits        14986    14985       -1     
- Misses       8760     8765       +5     
  Partials      266      266              
Flag Coverage Δ
server-test 73.97% <ø> (ø)
unittest 38.71% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Brooooooklyn Brooooooklyn changed the title fix: viewport element not found in share page fix(core): viewport element not found in share page Apr 10, 2024
@Brooooooklyn Brooooooklyn merged commit 7d131ee into toeverything:canary Apr 10, 2024
35 of 37 checks passed
@L-Sun L-Sun deleted the fix-shared-page-bug branch April 10, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants