Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(component): sign up password max length notify #6467

Merged
merged 1 commit into from Apr 10, 2024

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Apr 6, 2024

The input maxLength causes password to be automatically truncated without notice user.

Copy link

graphite-app bot commented Apr 6, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

Copy link
Member Author

EYHN commented Apr 6, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @EYHN and the rest of your teammates on Graphite Graphite

@EYHN EYHN marked this pull request as ready for review April 6, 2024 08:05
Copy link

nx-cloud bot commented Apr 6, 2024

@EYHN EYHN changed the title fix(components): sign up password max length notify fix(component): sign up password max length notify Apr 6, 2024
Copy link

codecov bot commented Apr 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.28%. Comparing base (a83f49e) to head (939fa9c).

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #6467   +/-   ##
=======================================
  Coverage   62.28%   62.28%           
=======================================
  Files         519      519           
  Lines       24048    24048           
  Branches     2275     2275           
=======================================
  Hits        14979    14979           
  Misses       8797     8797           
  Partials      272      272           
Flag Coverage Δ
server-test 73.82% <ø> (ø)
unittest 38.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Apr 10, 2024

Merge activity

The input `maxLength` causes password to be automatically truncated without notice user.
@Brooooooklyn Brooooooklyn force-pushed the eyhn/fix/signup-password-max-length branch from 8844f9e to 939fa9c Compare April 10, 2024 06:20
@graphite-app graphite-app bot merged commit 939fa9c into canary Apr 10, 2024
36 of 40 checks passed
@graphite-app graphite-app bot deleted the eyhn/fix/signup-password-max-length branch April 10, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants