Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): create and open cloud workspace if not exists after logged in #6511

Merged

Conversation

CatsJuice
Copy link
Member

@CatsJuice CatsJuice commented Apr 11, 2024

Only execute when initCloud=true is specified in the URL search params.

Copy link

graphite-app bot commented Apr 11, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CatsJuice and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Apr 11, 2024

@CatsJuice CatsJuice marked this pull request as ready for review April 11, 2024 01:09
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 61.48%. Comparing base (e77475a) to head (6a535b9).

Files Patch % Lines
packages/frontend/core/src/pages/index.tsx 0.00% 24 Missing ⚠️
...ges/frontend/core/src/hooks/use-navigate-helper.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6511      +/-   ##
==========================================
- Coverage   61.61%   61.48%   -0.13%     
==========================================
  Files         526      526              
  Lines       25920    25942      +22     
  Branches     2327     2330       +3     
==========================================
- Hits        15970    15951      -19     
- Misses       9676     9717      +41     
  Partials      274      274              
Flag Coverage Δ
server-test 71.54% <ø> (-0.11%) ⬇️
unittest 38.68% <0.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CatsJuice CatsJuice force-pushed the catsjuice/feat/create-cloud-if-not-exits-after-logged-in branch from 1dc5850 to 23b4d08 Compare April 11, 2024 01:14
Copy link
Member Author

@CatsJuice CatsJuice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hwangdev97 cc
A trigger has been added, with the parameter initCloud=true specified in the URL.

@CatsJuice CatsJuice force-pushed the catsjuice/feat/create-cloud-if-not-exits-after-logged-in branch from 23b4d08 to faf1ea7 Compare April 11, 2024 13:47
@CatsJuice CatsJuice force-pushed the catsjuice/feat/create-cloud-if-not-exits-after-logged-in branch from faf1ea7 to 862267d Compare April 12, 2024 06:14
Copy link

graphite-app bot commented Apr 12, 2024

Merge activity

…d in (#6511)

Only execute when `initCloud=true` is specified in the URL search params.
@EYHN EYHN force-pushed the catsjuice/feat/create-cloud-if-not-exits-after-logged-in branch from 862267d to 6a535b9 Compare April 12, 2024 09:55
@graphite-app graphite-app bot merged commit 6a535b9 into canary Apr 12, 2024
36 of 40 checks passed
@graphite-app graphite-app bot deleted the catsjuice/feat/create-cloud-if-not-exits-after-logged-in branch April 12, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

2 participants