-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(component): adjust notify styles #6578
Conversation
Your org has enabled the Graphite merge queue for merging into canaryAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit bcee1bb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## canary #6578 +/- ##
==========================================
- Coverage 61.34% 61.33% -0.02%
==========================================
Files 573 573
Lines 26259 26265 +6
Branches 2295 2298 +3
==========================================
+ Hits 16109 16110 +1
- Misses 9886 9891 +5
Partials 264 264
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
a492fa1
to
02a387b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think maybe you can give default icon color based on the given theme in the impl of notify
d1169da
to
0bc91f3
Compare
Merge activity
|
Change the styles of `notify.error`, `notify.warning`, and `notify.success` from `alert` to `normal` Add custom `iconColor` option
0bc91f3
to
54b732a
Compare
Change the styles of `notify.error`, `notify.warning`, and `notify.success` from `alert` to `normal` Add custom `iconColor` option
54b732a
to
bcee1bb
Compare
Change the styles of
notify.error
,notify.warning
, andnotify.success
fromalert
tonormal
Add custom
iconColor
option