Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(component): adjust notify styles #6578

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented Apr 16, 2024

Change the styles of notify.error, notify.warning, and notify.success from alert to normal
Add custom iconColor option

Copy link

graphite-app bot commented Apr 16, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

Copy link
Member Author

JimmFly commented Apr 16, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JimmFly and the rest of your teammates on Graphite Graphite

@JimmFly JimmFly marked this pull request as ready for review April 16, 2024 07:18
Copy link

nx-cloud bot commented Apr 16, 2024

@JimmFly JimmFly changed the title feat(core): adjust motify styles feat(component): adjust motify styles Apr 16, 2024
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 61.33%. Comparing base (8b66c1d) to head (bcee1bb).

Files Patch % Lines
...es/frontend/component/src/ui/notification/utils.ts 20.00% 4 Missing ⚠️
...ponent/src/ui/notification/notification-center.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6578      +/-   ##
==========================================
- Coverage   61.34%   61.33%   -0.02%     
==========================================
  Files         573      573              
  Lines       26259    26265       +6     
  Branches     2295     2298       +3     
==========================================
+ Hits        16109    16110       +1     
- Misses       9886     9891       +5     
  Partials      264      264              
Flag Coverage Δ
server-test 70.61% <ø> (ø)
unittest 39.59% <28.57%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JimmFly JimmFly changed the title feat(component): adjust motify styles feat(component): adjust notify styles Apr 16, 2024
Copy link
Collaborator

@pengx17 pengx17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think maybe you can give default icon color based on the given theme in the impl of notify

@JimmFly JimmFly force-pushed the jimmfly/0416/notification branch 2 times, most recently from d1169da to 0bc91f3 Compare April 17, 2024 09:02
Copy link

graphite-app bot commented Apr 17, 2024

Merge activity

  • Apr 17, 7:44 AM EDT: pengx17 added this pull request to the Graphite merge queue.
  • Apr 17, 7:58 AM EDT: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: '3, 2, 1 Launch', 'Server Test').
  • Apr 17, 8:35 AM EDT: Brooooooklyn added this pull request to the Graphite merge queue.
  • Apr 17, 8:47 AM EDT: Brooooooklyn merged this pull request with the Graphite merge queue.

pengx17 pushed a commit that referenced this pull request Apr 17, 2024
Change the styles of `notify.error`, `notify.warning`, and `notify.success` from `alert` to `normal`
Add custom `iconColor` option
Change the styles of `notify.error`, `notify.warning`, and `notify.success` from `alert` to `normal`
Add custom `iconColor` option
@graphite-app graphite-app bot merged commit bcee1bb into canary Apr 17, 2024
32 checks passed
@graphite-app graphite-app bot deleted the jimmfly/0416/notification branch April 17, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants