Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(component): banner should not affect the editor layout #6605

Merged
merged 1 commit into from Apr 18, 2024

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Apr 18, 2024

Screen.Recording.2024-04-17.at.23.23.47.mov

Copy link

graphite-app bot commented Apr 18, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

fundon commented Apr 18, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fundon and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Apr 18, 2024

@fundon fundon marked this pull request as ready for review April 18, 2024 01:36
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.06%. Comparing base (9cb6dcd) to head (5437c65).
Report is 1 commits behind head on canary.

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #6605   +/-   ##
=======================================
  Coverage   61.06%   61.06%           
=======================================
  Files         574      574           
  Lines       26489    26489           
  Branches     2308     2308           
=======================================
  Hits        16175    16175           
  Misses      10050    10050           
  Partials      264      264           
Flag Coverage Δ
server-test 70.16% <ø> (ø)
unittest 39.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fundon fundon force-pushed the 04_17_fix-affine-banner-position branch from 21c976c to 2cf4703 Compare April 18, 2024 01:44
@fundon fundon requested review from JimmFly and EYHN April 18, 2024 03:08
Copy link

graphite-app bot commented Apr 18, 2024

Merge activity

@EYHN EYHN force-pushed the 04_17_fix-affine-banner-position branch from 2cf4703 to 5437c65 Compare April 18, 2024 13:16
@graphite-app graphite-app bot merged commit 5437c65 into canary Apr 18, 2024
32 checks passed
@graphite-app graphite-app bot deleted the 04_17_fix-affine-banner-position branch April 18, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

2 participants