Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add subscribe link #6610

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Apr 18, 2024

No description provided.

Copy link

graphite-app bot commented Apr 18, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

Copy link
Member Author

EYHN commented Apr 18, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @EYHN and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Apr 18, 2024

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 61.05%. Comparing base (5437c65) to head (09832dc).

Files Patch % Lines
...s/frontend/core/src/modules/cloud/services/auth.ts 0.00% 4 Missing ⚠️
...ges/frontend/core/src/hooks/use-navigate-helper.ts 0.00% 2 Missing ⚠️
...rontend/core/src/modules/cloud/entities/session.ts 0.00% 2 Missing ⚠️
...nd/core/src/modules/cloud/entities/subscription.ts 0.00% 2 Missing ⚠️
packages/frontend/core/src/router.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6610      +/-   ##
==========================================
- Coverage   61.13%   61.05%   -0.09%     
==========================================
  Files         574      574              
  Lines       26489    26493       +4     
  Branches     2309     2311       +2     
==========================================
- Hits        16194    16175      -19     
- Misses      10031    10054      +23     
  Partials      264      264              
Flag Coverage Δ
server-test 70.16% <ø> (-0.10%) ⬇️
unittest 39.50% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EYHN EYHN marked this pull request as ready for review April 18, 2024 09:18
@EYHN EYHN force-pushed the eyhn/feat/subscribe-link branch 2 times, most recently from 4235d87 to 587d263 Compare April 18, 2024 09:22
Copy link

graphite-app bot commented Apr 18, 2024

Merge activity

@graphite-app graphite-app bot merged commit 09832dc into canary Apr 18, 2024
32 checks passed
@graphite-app graphite-app bot deleted the eyhn/feat/subscribe-link branch April 18, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants