Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): show login modal if not logged in when using ai #6632

Merged
merged 1 commit into from Apr 22, 2024

Conversation

CatsJuice
Copy link
Member

@CatsJuice CatsJuice commented Apr 19, 2024

CleanShot 2024-04-22 at 09.05.42.gif

Copy link

graphite-app bot commented Apr 19, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

Copy link

sentry-io bot commented Apr 19, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: packages/frontend/core/src/providers/modal-provider.tsx

Function Unhandled Issue
CurrentWorkspaceModals React ErrorBoundary GraphQLError: GraphQL query responds unexpected result (@affine/monorepo/./packages/fronte...
Event Count: 9 Affected Users: 2
CurrentWorkspaceModals React ErrorBoundary GraphQLError: GraphQL query responds unexpected result (@affine/monorepo/packages/fro...
Event Count: 1 Affected Users: 1

Did you find this useful? React with a 👍 or 👎

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CatsJuice and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Apr 19, 2024

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.11%. Comparing base (efe3b05) to head (d7e0821).

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #6632   +/-   ##
=======================================
  Coverage   61.11%   61.11%           
=======================================
  Files         574      574           
  Lines       26503    26503           
  Branches     2304     2304           
=======================================
  Hits        16196    16196           
  Misses      10043    10043           
  Partials      264      264           
Flag Coverage Δ
server-test 70.21% <ø> (ø)
unittest 39.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the mod:i18n Related to i18n label Apr 19, 2024
@CatsJuice CatsJuice force-pushed the catsjuice/ai-401-confirm-login branch from eafa38f to e10961f Compare April 22, 2024 00:37
@CatsJuice CatsJuice requested a review from pengx17 April 22, 2024 01:06
@CatsJuice CatsJuice marked this pull request as ready for review April 22, 2024 01:15
Copy link

graphite-app bot commented Apr 22, 2024

Merge activity

@pengx17 pengx17 force-pushed the catsjuice/ai-401-confirm-login branch from e10961f to d7e0821 Compare April 22, 2024 03:26
@graphite-app graphite-app bot merged commit d7e0821 into canary Apr 22, 2024
33 checks passed
@graphite-app graphite-app bot deleted the catsjuice/ai-401-confirm-login branch April 22, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:i18n Related to i18n
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

4 participants