Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): open desktop directly in subscription landing page #6661

Merged

Conversation

CatsJuice
Copy link
Member

No description provided.

Copy link

graphite-app bot commented Apr 22, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added app:electron Related to electron app app:core labels Apr 22, 2024
Copy link
Member Author

CatsJuice commented Apr 22, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CatsJuice and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Apr 22, 2024

@CatsJuice CatsJuice marked this pull request as ready for review April 22, 2024 08:27
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 9.09091% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 61.12%. Comparing base (71a5be5) to head (6ec97b2).

Files Patch % Lines
...tend/core/src/modules/cloud/stores/subscription.ts 12.50% 7 Missing ⚠️
...ges/frontend/core/src/hooks/use-navigate-helper.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6661      +/-   ##
==========================================
- Coverage   61.17%   61.12%   -0.06%     
==========================================
  Files         574      574              
  Lines       26515    26526      +11     
  Branches     2306     2309       +3     
==========================================
- Hits        16221    16214       -7     
- Misses      10031    10048      +17     
- Partials      263      264       +1     
Flag Coverage Δ
server-test 70.26% <ø> (-0.01%) ⬇️
unittest 39.48% <9.09%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CatsJuice CatsJuice force-pushed the catsjuice/feat/subscription-landing-open-in-app branch from c3d3b2d to 0286054 Compare April 22, 2024 08:39
@CatsJuice CatsJuice requested review from EYHN and pengx17 April 22, 2024 08:40
@EYHN EYHN force-pushed the catsjuice/feat/ai-subscription-landing-page branch from f70c827 to e130245 Compare April 22, 2024 09:03
@EYHN EYHN changed the base branch from catsjuice/feat/ai-subscription-landing-page to canary April 22, 2024 09:13
@CatsJuice CatsJuice force-pushed the catsjuice/feat/subscription-landing-open-in-app branch from 0286054 to e556872 Compare April 22, 2024 12:32
Copy link

graphite-app bot commented Apr 22, 2024

Merge activity

@EYHN EYHN force-pushed the catsjuice/feat/subscription-landing-open-in-app branch from e556872 to 6ec97b2 Compare April 22, 2024 14:22
@graphite-app graphite-app bot merged commit 6ec97b2 into canary Apr 22, 2024
32 checks passed
@graphite-app graphite-app bot deleted the catsjuice/feat/subscription-landing-open-in-app branch April 22, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core app:electron Related to electron app
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

2 participants