-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): update prompts #6738
Conversation
Your org has enabled the Graphite merge queue for merging into canaryAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 7c5a259. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## canary #6738 +/- ##
=======================================
Coverage 64.79% 64.79%
=======================================
Files 581 581
Lines 27188 27188
Branches 2427 2427
=======================================
Hits 17617 17617
Misses 9306 9306
Partials 265 265
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Merge activity
|
Update prompts: When sending a message to openai, we actually send two messages. There are two issues here: 1. the role in the first message shall be user or system 2. the content in the first message is not being interpolated at all. ``` [ { role: "assistant", createdAt: "2024-04-27T06:30:34.820Z", params: { language: "French", }, content: "You are a translation expert, please translate the following content into French, and only perform the translation action, keeping the translated content in the same format as the original content:\n\n \"\"\"\"\n\n \n\n \"\"\"\"", }, { role: "user", content: "Basic things you should know:", attachments: undefined, params: { language: "French", }, createdAt: "2024-04-29T09:42:11.466Z", }, ] ``` In this PR I removed `content` from prompts and let open ai use the second message (user) as the input.
e86d107
to
7c5a259
Compare
Update prompts:
When sending a message to openai, we actually send two messages.
There are two issues here:
In this PR I removed
content
from prompts and let open ai use the second message (user) as the input.